-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNUisms in Makefile.fragment cause BSD make not to install headers #4
Comments
Hey! At the end of
Just tried that, and both headers were installed. Thanks! |
Weirdly, there is no reference to that header at any point during the config/build/install:
|
Strange. What's your PEAR version?
Can you try upgrading PEAR?
|
This is a fresh install of just-released 5.6.18:
Running "pear upgrade" only tries (unsuccessfully) to upgrade propro and raphf to the versions that require PHP 7:
Thanks! |
Just reproduced on a freebsd vm. |
With that clue, it was possible to narrow the issue down to some difference between BSD make and GNU make. The following will work:
The same is required for propro. Then, pecl_http will build without include errors. That's easy enough, so we're all set. But if you want to explore it further, this must be related to some recent Makefile change. It looks like we previously built this OK with raphf 1.1.0, so at a glance it might be this commit: Thanks! |
Yep, just verified myself as a bsd/gnu make issue, maybe bsd make barfs on the |
...or doesn't it support pattern rules? |
This make is new with 10.x so I don't know its ins and outs yet, but the old version definitely handled pattern rules quite differently. E.g. instead of: %.o: %.c It (IIRC) used something else called a "transformation rule" that looks like: .c.o: From a glance at the man page, it looks like the new version still does it that way. |
Apparently I have multiple GNUisms in my Makefile: https://github.com/m6w6/ext-raphf/blob/master/Makefile.frag#L3 Thanks for the report, I'll think about a proper fix. |
Under PHP 5.6.18 after a successful/uneventful "pecl install raphf-1.1.2" the extension is there, but the installed file include/php/ext/raphf/php_raphf.h contains the line:
However, this file is not present:
This causes dependencies (i.e. pecl_http 2.5.5) to fail to build:
The text was updated successfully, but these errors were encountered: