Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc build with old sphinx #102

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Conversation

remicollet
Copy link
Contributor

Only encountered on quite old RHEL 7 (python-sphinx 1.1.3)

Exception occurred:
  File "/usr/lib/python2.7/site-packages/sphinx/util/__init__.py", line 85, in get_matching_docs
    suffixpattern = '*' + suffix
TypeError: cannot concatenate 'str' and 'list' objects

@remicollet
Copy link
Contributor Author

remicollet commented Dec 23, 2020

Additional notice, on EL-7 also have to disable BUILD_DOCS_MANGZ as it use -k gzip option which doesn't exit on old gzip version 1.5

@remicollet
Copy link
Contributor Author

Thanks to this patch, I was able to build libmemcached on Fedora 31 to 33 and RHEL 7 and 8

@m6w6 m6w6 merged commit c517ea8 into awesomized:v1.x Dec 25, 2020
@remicollet remicollet deleted the issue-oldsphinx branch December 26, 2020 05:51
m6w6 added a commit that referenced this pull request Dec 28, 2020
**Changes from beta1:**

* Fix [gh #103](#103):
  Build failure on 32-bit.
* Fix [gh #102](#102):
  Doc build with old sphinx.
* Fix [gh #100](#100):
  Revert symbolic rename of public header include directories.
* Fix [gh #98](#98):
  Library SONAMEs and NAME_LINKs differ from 1.0.18.
* Fix [gh #97](#97):
  Location of cmake files installation directory.
* Fix [gh #96](#96):
  LIBXXX_VERSION_HEX constants format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants