Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buid failure on 32-bit #103

Closed
remicollet opened this issue Dec 23, 2020 · 1 comment
Closed

Buid failure on 32-bit #103

remicollet opened this issue Dec 23, 2020 · 1 comment

Comments

@remicollet
Copy link
Contributor

Running a Fedora scratch build
https://koji.fedoraproject.org/koji/taskinfo?taskID=58114962 (available for a short time)

32-bit builds (armv7hl and i686) are failing

/builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/MemcachedCluster.cpp: In member function 'void MemcachedCluster::killOneServer() const':
/builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/MemcachedCluster.cpp:146:66: error: no matching function for call to 'random_num(long unsigned int, std::vector<Server>::size_type)'
  146 |   const auto &victim = servers[random_num(0UL, servers.size() - 1)];
      |                                                                  ^
In file included from /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/common.hpp:33,
                 from /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/MemcachedCluster.hpp:18,
                 from /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/MemcachedCluster.cpp:1:
/builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/random.hpp:37:34: note: candidate: 'template<class T> std::enable_if_t<is_integral_v<T>, T> random_num(T, T)'
   37 | enable_if_t<is_integral_v<T>, T> random_num(T min, T max) {
      |                                  ^~~~~~~~~~
/builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/random.hpp:37:34: note:   template argument deduction/substitution failed:
/builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/MemcachedCluster.cpp:146:66: note:   deduced conflicting types for parameter 'T' ('long unsigned int' and 'unsigned int')
  146 |   const auto &victim = servers[random_num(0UL, servers.size() - 1)];
  
    |                                                                  ^

And


In file included from /usr/include/c++/11/ios:40,
                 from /usr/include/c++/11/ostream:38,
                 from /usr/include/c++/11/iostream:39,
                 from /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/common.hpp:20,
                 from /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/Cluster.hpp:18,
                 from /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/Cluster.cpp:1:
In function 'std::char_traits<char>::copy(char*, char const*, unsigned int)',
    inlined from 'std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy(char*, char const*, unsigned int)' at /usr/include/c++/11/bits/basic_string.h:351:21,
    inlined from 'std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_copy(char*, char const*, unsigned int)' at /usr/include/c++/11/bits/basic_string.h:346:7,
    inlined from 'std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace(unsigned int, unsigned int, char const*, unsigned int)' at /usr/include/c++/11/bits/basic_string.tcc:481:20,
    inlined from 'std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(char const*)' at /usr/include/c++/11/bits/basic_string.h:1445:19,
    inlined from 'std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::operator=(char const*)' at /usr/include/c++/11/bits/basic_string.h:676:28,
    inlined from 'std::__exchange<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, char const (&) [6]>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, char const (&) [6])std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >' at /usr/include/c++/11/bits/move.h:155:13,
    inlined from 'std::exchange<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, char const (&) [6]>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, char const (&) [6])std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >' at /usr/include/c++/11/utility:292:65,
    inlined from 'Server::operator=(Server&&) [clone .isra.0]' at /builddir/build/BUILD/libmemcached-2f275201aac9994f7694acb67f5dee62adcb0424/test/lib/Server.hpp:43:40:
/usr/include/c++/11/bits/char_traits.h:402:56: warning: 'memcpy' reading 5 bytes from a region of size 1 [-Wstringop-overread]
  402 |         return static_cast<char_type*>(__builtin_memcpy(__s1, __s2, __n));
      |                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~

@m6w6
Copy link
Collaborator

m6w6 commented Dec 24, 2020

Maerged! Thank you!

@m6w6 m6w6 closed this as completed Dec 24, 2020
m6w6 added a commit that referenced this issue Dec 28, 2020
**Changes from beta1:**

* Fix [gh #103](#103):
  Build failure on 32-bit.
* Fix [gh #102](#102):
  Doc build with old sphinx.
* Fix [gh #100](#100):
  Revert symbolic rename of public header include directories.
* Fix [gh #98](#98):
  Library SONAMEs and NAME_LINKs differ from 1.0.18.
* Fix [gh #97](#97):
  Location of cmake files installation directory.
* Fix [gh #96](#96):
  LIBXXX_VERSION_HEX constants format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants