Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI/API compatibility with 1.0.18 #96

Closed
remicollet opened this issue Dec 21, 2020 · 0 comments
Closed

ABI/API compatibility with 1.0.18 #96

remicollet opened this issue Dec 21, 2020 · 0 comments

Comments

@remicollet
Copy link
Contributor

remicollet commented Dec 21, 2020

Using 1.x branch on 802aeb5

See

https://rpms.remirepo.net/compat_reports/libmemcached/1.0.18_to_1.0.99/compat_report.html
https://rpms.remirepo.net/compat_reports/libmemcachedutil/1.0.18_to_1.0.99/compat_report.html
https://rpms.remirepo.net/compat_reports/libmemcachedprotocol/1.0.18_to_1.0.99/compat_report.html
https://rpms.remirepo.net/compat_reports/libhashkit/1.0.18_to_1.0.99/compat_report.html

I see 2 annoying changes in ABI

The value of constant LIBHASHKIT_VERSION_HEX has been changed from 0x01000000 to 0x010000
The value of constant LIBMEMCACHED_VERSION_HEX has been changed from 0x01000018 to 0x010100

Having "lower" value in newer can be a real problem
(ex https://github.com/php-memcached-dev/php-memcached/blob/v3.1.5/php_memcached.c#L376)

@m6w6 m6w6 closed this as completed in 4ca28fb Dec 21, 2020
m6w6 added a commit that referenced this issue Dec 28, 2020
**Changes from beta1:**

* Fix [gh #103](#103):
  Build failure on 32-bit.
* Fix [gh #102](#102):
  Doc build with old sphinx.
* Fix [gh #100](#100):
  Revert symbolic rename of public header include directories.
* Fix [gh #98](#98):
  Library SONAMEs and NAME_LINKs differ from 1.0.18.
* Fix [gh #97](#97):
  Location of cmake files installation directory.
* Fix [gh #96](#96):
  LIBXXX_VERSION_HEX constants format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant