Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design the tag fetching mechanism #148

Open
LCaparelli opened this issue Sep 4, 2020 · 0 comments
Open

Re-design the tag fetching mechanism #148

LCaparelli opened this issue Sep 4, 2020 · 0 comments
Assignees
Labels
enhancement 👑 New feature or request
Milestone

Comments

@LCaparelli
Copy link
Member

Currently, the tags are fetched using github.com/heroku/docker-registry-client/registry, which does not export its client as an interface. This means we can't easily mock a client by simply implementing an interface, which would come in very handy for testing.

We could wrap their client into an interface of our own and use that for production code as well as in testing, thus allowing us to create a mock registry client from that interface as well.

That would give us the power to conduct deterministic tests by emulating the registry client. This granularity would allow us to test the errors and achieve 100% test coverage in the package.

@LCaparelli LCaparelli added the enhancement 👑 New feature or request label Sep 4, 2020
@LCaparelli LCaparelli added this to the v0.4.0 milestone Sep 4, 2020
@LCaparelli LCaparelli self-assigned this Sep 4, 2020
@ricardozanini ricardozanini modified the milestones: v0.4.0, v0.5.0 Oct 27, 2020
@ricardozanini ricardozanini modified the milestones: v0.5.0, v0.6.0 Dec 9, 2020
@ricardozanini ricardozanini modified the milestones: v0.6.0, v0.7.0 Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👑 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants