Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Support for newer browser #1

Closed
lippit opened this issue Aug 6, 2012 · 14 comments
Closed

Support for newer browser #1

lippit opened this issue Aug 6, 2012 · 14 comments
Assignees

Comments

@lippit
Copy link

lippit commented Aug 6, 2012

Cwebsocket does not work with newer browsers, like latest Chrome or Firefox, probably because it only supports Websockets Draft 76, but not RFC 6455

Are you going to support RFC 6455?

@felipecruz
Copy link

Hey!

I forked this project but I re-implemented almost everything. It supports only rfc 6455 - https://github.com/felipecruz/cws/

Copyrights to the original author are in the source files.

@lippit
Copy link
Author

lippit commented Aug 6, 2012

Am 06.08.2012, 20:57 Uhr, schrieb Felipe cruz
reply@reply.github.com:

Hey!

I forked this project but I re-implemented almost everything. It
supports only rfc 6455 - https://github.com/felipecruz/cws/

Ah, that's great, thanks a lot!
I'll try and then likely switch to your fork.

Best regards,

Georg

@felipecruz
Copy link

just to clarify..

I created another repo because I wanted to create a library for rfc 6455 version only.. but I really liked the original API and some code :)

hope this isn't a problem!

@m8rge
Copy link
Owner

m8rge commented Aug 7, 2012

@felipecruz Generally, this library wasn't created only for draft 76. I wish you fork from this repository and create upgraded version. If you make this, 23 peoples, who wathing this repo will knew about you changes. At this moment even I don't know about your fork.

@felipecruz
Copy link

I'm sorry.. but I won't do that..
give me a few weeks and I'll remove your code from my repo..

@lippit
Copy link
Author

lippit commented Aug 7, 2012

Hi,

just tried your CWS library, but did not get it to work as expected.
I managed to compile, and also ws_parse_input_frame returns
WS_TEXT_FRAME, but the content of the frame is only crap. It looks as if
there where random bytes in it, but not the text message expected.

Any ideas?

Thanks,

Georg

@m8rge
Copy link
Owner

m8rge commented Aug 8, 2012

@lippit If your asking felipecruz - make issue in https://github.com/felipecruz/cws/ repo

@m8rge
Copy link
Owner

m8rge commented Aug 8, 2012

And I think, I'll support RFC 6455. I'll make this in few weeks

@jpproulx
Copy link

I see you added support for RFC 6455 which is great. Are you planning on keeping hixie76 support for backward compatibility (i.e. iOS 5.1)?

@m8rge
Copy link
Owner

m8rge commented Aug 20, 2012

@jpproulx I'll read about this. First I'll make rfc support and then will introduce hixie76 support.

@m8rge
Copy link
Owner

m8rge commented Aug 21, 2012

@jpproulx I'll try keep backward compatability if it's implementable.

@m8rge
Copy link
Owner

m8rge commented Aug 21, 2012

@jpproulx I'll see on headers like Sec-WebSocket-Key1 and Sec-WebSocket-Version to determine which protocol version use

@ghost ghost assigned m8rge Aug 21, 2012
@m8rge
Copy link
Owner

m8rge commented Oct 1, 2012

@jpproulx Safari in iOS 6 have built-in support for RFC 6455. I think that it is not nesesary to keep backward compatability with hixie76 draft in cwebsocket library

@m8rge
Copy link
Owner

m8rge commented May 13, 2013

@m8rge m8rge closed this as completed May 13, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants