Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ble tags blackList #99

Closed
wants to merge 2 commits into from
Closed

Ble tags blackList #99

wants to merge 2 commits into from

Conversation

monster1025
Copy link

@monster1025 monster1025 commented Jan 22, 2020

Hi.
I am using blacklist for tags to filter neighbor ble devices (but i can't use whitelist because i need to add my changed tags to all room-assistant instances - maybe mqtt-whitelist can be added?). So I have implemented simple blacklist here.

Maybe it will be useful for others.

@mKeRix
Copy link
Owner

mKeRix commented Jan 22, 2020

Thanks for the contribution! At the moment I've been doing a major rewrite of room-assistant to implement it a bit cleaner and make room for more advanced integrations. I don't think I will push out a release with the old code base anymore - but I will keep this open for now, for visibility. I will push it into master should my refactoring plans fail.

Nonetheless, I will keep this use case in mind while coding on my new version. Especially the topic of centralized configuration ("mqtt whitelist") is something I'm interested in, but unsure on how it can be solved the best.

@monster1025
Copy link
Author

ok, will wait for new release. Thanks! =)

mKeRix added a commit that referenced this pull request Mar 22, 2020
Promised this to @monster1025 in #99! Blacklist trumps whitelist.
github-actions bot pushed a commit that referenced this pull request Mar 22, 2020
# [2.2.0](v2.1.1...v2.2.0) (2020-03-22)

### Bug Fixes

* **bluetooth-classic:** ignore requests for undefined addresses ([ed733a3](ed733a3)), closes [#136](#136)

### Features

* **bluetooth-classic:** add options for interval and timeout ([c5b181f](c5b181f)), closes [#147](#147) [#142](#142)
* **bluetooth-low-energy:** add blacklist option ([0f6eac4](0f6eac4)), closes [#99](#99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants