Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPAppDelegateProxy does not forward protocol conformance #143

Closed
cbaltzer opened this issue Mar 25, 2022 · 1 comment
Closed

MPAppDelegateProxy does not forward protocol conformance #143

cbaltzer opened this issue Mar 25, 2022 · 1 comment

Comments

@cbaltzer
Copy link
Contributor

cbaltzer commented Mar 25, 2022

We have a React Native app that uses mParticle in combination with react-native-app-auth. Implementing this involves adding a property and a protocol to our AppDelegate.

MPAppDelegateProxy is intercepting calls to the app delegate, which is normally no problem because it forwards all selectors. However, it appears that RN checks conformsToProtocol before calling the selector, which MPAppDelegateProxy does not implement. The flow works if we add the necessary protocol to MPAppDelegateProxy directly, but that's not a workable solution as it gets overwritten any time we do a pod install (in CI/CD builds for example).

PR: #144

@einsteinx2
Copy link
Contributor

This fix has just gone out with release v8.8.0: https://github.com/mParticle/mparticle-apple-sdk/releases/tag/v8.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants