Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Limit Currency Values to 2 Decimal Points #183

Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix: Limit Currency Values to 2 Decimal Points #183

merged 2 commits into from
Feb 22, 2023

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Change number formatter to 2 decimals

Testing Plan

  • Tested locally and updated unit test to check

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Feb 21, 2023
@BrandonStalnaker BrandonStalnaker force-pushed the fix/4795-Limit-Currency-Values-to-2-Decimals branch from 76d7e32 to 2239f3e Compare February 21, 2023 19:33
@BrandonStalnaker BrandonStalnaker changed the base branch from main to development February 21, 2023 19:35
@BrandonStalnaker BrandonStalnaker force-pushed the fix/4795-Limit-Currency-Values-to-2-Decimals branch from 2239f3e to 2cd8d80 Compare February 22, 2023 15:18
@BrandonStalnaker BrandonStalnaker force-pushed the fix/4795-Limit-Currency-Values-to-2-Decimals branch from 2cd8d80 to 2f1334d Compare February 22, 2023 15:29
einsteinx2
einsteinx2 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit de70c03 into development Feb 22, 2023
@BrandonStalnaker BrandonStalnaker deleted the fix/4795-Limit-Currency-Values-to-2-Decimals branch February 22, 2023 17:59
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Mar 14, 2023
@mparticle-automation
chore(release): 8.12.0 [skip ci]
0f0befb 
# [8.12.0](v8.11.2...v8.12.0) (2023-03-14)

### Bug Fixes

* Limit Currency Values to 2 Decimal Points ([#183](#183)) ([de70c03](de70c03))

### Features

* Custom local kit loading aka kit sideloading ([#185](#185)) ([a279cb0](a279cb0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrandonStalnaker @mparticle-automation @einsteinx2