Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Tracking Support for Custom Domains #274

Merged
merged 1 commit into from
May 1, 2024
Merged

feat: Add Tracking Support for Custom Domains #274

merged 1 commit into from
May 1, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Added mParticle Option for custom tracking domains

Testing Plan

  • Added unit test coverage and tested functionality manually as possible

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Apr 29, 2024
einsteinx2
einsteinx2 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Zoom, LGTM

@BrandonStalnaker BrandonStalnaker merged commit 1584dae into development May 1, 2024
11 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/6220-Add-CName-Support-for-Tracking-Domains branch May 1, 2024 15:47
mparticle-automation added a commit that referenced this pull request May 1, 2024
@mparticle-automation
chore(release): 8.24.0 [skip ci]
18b4d87 
# [8.24.0](v8.23.1...v8.24.0) (2024-05-01)

### Bug Fixes

* Allow Alias When Start and End Time Not Set ([#275](#275)) ([241ecd4](241ecd4))

### Features

* Add Tracking Support for Custom Domains ([#274](#274)) ([1584dae](1584dae))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrandonStalnaker @mparticle-automation @einsteinx2