Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Forwarding ATT status to kits #276

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: Forwarding ATT status to kits #276

merged 1 commit into from
Apr 30, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • We already had an optional protocol method for this but weren't actually forwarding when set on mParticle object. This adds that forwarding as it's necessary for the latest Braze SDK update and iOS 17 app tracking stuff.

Testing Plan

  • Was this tested locally? If not, explain why.
  • E2E tested to see that the kit correctly received the status, tested with both an NSNumber and nil for the timestamp.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 changed the base branch from main to development April 30, 2024 20:44
BrandonStalnaker
BrandonStalnaker approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through the changes with Ben on a call. LGTM!

@einsteinx2 einsteinx2 merged commit 9fd95f7 into development Apr 30, 2024
10 of 11 checks passed
mparticle-automation added a commit that referenced this pull request Apr 30, 2024
@mparticle-automation
chore(release): 8.23.1 [skip ci]
da4bade 
## [8.23.1](v8.23.0...v8.23.1) (2024-04-30)

### Bug Fixes

* Forwarding ATT status to kits ([#276](#276)) ([9fd95f7](9fd95f7))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.23.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@einsteinx2 einsteinx2 deleted the feat/6409-forward-att-status-to-kits branch June 7, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@einsteinx2 @mparticle-automation @BrandonStalnaker