Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Record PushRegistration Correctly in UI #280

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • The push registration notification was not passing the correct userinfo. This made the UI read it as an unregister rather than a register

Testing Plan

  • Tested in a sample app and confirmed end to end

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love simple fixes :)

approved

@BrandonStalnaker BrandonStalnaker merged commit 2d124ec into development Jun 7, 2024
11 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/6516-Record-PushRegistration-Correctly-in-UI branch June 7, 2024 15:11
mparticle-automation added a commit that referenced this pull request Jun 10, 2024
## [8.24.2](v8.24.1...v8.24.2) (2024-06-10)

### Bug Fixes

* Record PushRegistration Correctly in UI ([#280](#280)) ([2d124ec](2d124ec))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.24.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants