Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Error in fritzbox_file_session.py (Python 3.9.x) #16

Closed
wvogel opened this issue Dec 11, 2023 · 2 comments · Fixed by #17
Closed

Runtime Error in fritzbox_file_session.py (Python 3.9.x) #16

wvogel opened this issue Dec 11, 2023 · 2 comments · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@wvogel
Copy link

wvogel commented Dec 11, 2023

Solved runtime error
I am experiencing runtime errors for serveral plugins because of line 40 in fritzbox_file_session.py:
def load(self) -> None | str:
Might be related to a Python version below 3.10 (3.9.2 is current on Raspberry Pi OS) and can be solved by adding "":
def load(self) -> "None | str":
All plugins run smoothly after this change.
[I included this in my pull request]

@ma4nn ma4nn changed the title Runtime Error in fritzbox_file_session.py [Solution included] Runtime Error in fritzbox_file_session.py (Python 3.9.x) Dec 12, 2023
@ma4nn ma4nn added the bug Something isn't working label Dec 12, 2023
@ma4nn ma4nn self-assigned this Dec 12, 2023
@ma4nn
Copy link
Owner

ma4nn commented Dec 12, 2023

Hi @wvogel,

thanks for your feedback!

Yes you're right, this is because of the (old) Python version from 2021-02. As mentioned in the README the minimum required version currently is 3.10. But if 3.9.2 is the default on PiOS and it is supported until 2025-10, perhaps it makes sense to downgrade the requirement to >= 3.9.2 then.

@wvogel
Copy link
Author

wvogel commented Dec 12, 2023

Thanks @ma4nn,
it seems like this is actually the only line of code that would require 3.10. Running on 3.9.2 perfectly now with the changes suggested.
Installing a newer Python version on a P4 with SSD takes about 1 hour, so downgrading requirements would be quite an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants