Skip to content

Commit

Permalink
Merge 7e4c5a9 into 159d0e3
Browse files Browse the repository at this point in the history
  • Loading branch information
agoose77 committed Apr 23, 2020
2 parents 159d0e3 + 7e4c5a9 commit 35df87d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
5 changes: 3 additions & 2 deletions js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
},
"dependencies": {
"@jupyter-widgets/base": "^1 || ^2 || ^3 || ^4",
"@jupyter-widgets/controls": "^1.4.2",
"@jupyter-widgets/controls": "^1 || ^2",
"@jupyterlab/application": "^2.1.0",
"css-loader": "^0.28.4",
"d3": "^5.7.0",
"gl-matrix": "^2.0.0",
Expand Down Expand Up @@ -92,4 +93,4 @@
"data/",
"glsl/"
]
}
}
4 changes: 0 additions & 4 deletions js/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,3 @@ export * from "./tf";
export * from "./scatter";
export * from "./volume";
export * from "./mesh";
export * from "./utils";
export * from "./selectors";
export * from "./values";
export {semver_range as version} from "./utils";
8 changes: 5 additions & 3 deletions js/src/labplugin.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import * as base from "@jupyter-widgets/base";
import * as jupyter_volume from "./index";
import {semver_range} from "./utils";
import {JupyterFrontEnd, JupyterFrontEndPlugin} from '@jupyterlab/application';

const plugin = {
const plugin: JupyterFrontEndPlugin<void> = {
id: "ipyvolume",
requires: [base.IJupyterWidgetRegistry],
activate(app, widgets) {
activate(app: JupyterFrontEnd, widgets: base.IJupyterWidgetRegistry) {
widgets.registerWidget({
name: "ipyvolume",
version: jupyter_volume.version,
version: semver_range,
exports: jupyter_volume,
});
},
Expand Down
2 changes: 1 addition & 1 deletion js/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import isTypedArray from "is-typedarray";

// same strategy as: ipywidgets/jupyter-js-widgets/src/widget_core.ts, except we use ~
// so that N.M.x is allowed (we don't care about x, but we assume 0.2.x is not compatible with 0.3.x
export const semver_range = "~";
export const semver_range = require('../package.json').version;

export
function is_typedarray(obj) {
Expand Down

0 comments on commit 35df87d

Please sign in to comment.