Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom themes aren't loaded #71

Closed
itmecho opened this issue Jul 5, 2021 · 0 comments · Fixed by #72
Closed

Custom themes aren't loaded #71

itmecho opened this issue Jul 5, 2021 · 0 comments · Fixed by #72

Comments

@itmecho
Copy link
Contributor

itmecho commented Jul 5, 2021

Describe the bug
Setting

---
theme: ./theme.json
---

results in the theme not being loaded and instead the default theme is used.

To Reproduce
Steps to reproduce the behavior:

  1. Create presentation.md with the following content
---
theme: ./theme.json
---

# Heading 1
## Heading 2
  1. wget https://github.com/maaslalani/slides/raw/main/styles/theme.json
  2. Change the h1.prefix to >>
  3. Run slides presentation.md and see that the modified theme isn't loaded

Expected behavior
The specified theme file should be loaded

Additional context
Looks like the code doesn't handle this case? I feel like this function is missing any logic to handle a custom theme file?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add handling logic for custom theme files itmecho/slides
1 participant
@itmecho