Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code makes fisher information matrix be 0 #1

Open
dvoina13 opened this issue Feb 4, 2021 · 0 comments
Open

Code makes fisher information matrix be 0 #1

dvoina13 opened this issue Feb 4, 2021 · 0 comments

Comments

@dvoina13
Copy link

dvoina13 commented Feb 4, 2021

There's a bug on line 81 of model.py
Should be:
self.F_accum[v] = torch.add(torch.Tensor((self.F_accum[v])), torch.pow(loglikelihood_grads[v], 2).data)

(as far as I could see for the latest versions of torch, torch.add needs an output). The way code is written self.F_accum never gets updated and the Fisher matrix is just 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant