Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to let R.swift skip certain files #276

Closed
mac-cain13 opened this issue Oct 9, 2016 · 4 comments
Closed

Add ability to let R.swift skip certain files #276

mac-cain13 opened this issue Oct 9, 2016 · 4 comments

Comments

@mac-cain13
Copy link
Owner

It would be nice to have the ability to make R.swift skip certain files completely. This would make it easy to work around certain edge cases/issues or speed up generation times if needed.

This would be a workaround/solution for these issues:

Nicest solution would be a CLI flag that you can pass the path to a gitignore style file that describes what files should be ignored. Depending on how hard that would be we also could scale down to a plain list of files to ignore.

@shiraji
Copy link
Contributor

shiraji commented Oct 18, 2016

If no one work on this issue, can I contribute this project?

@mac-cain13
Copy link
Owner Author

@shiraji I did a little bit of fiddling around for this feature on the feature/skip-file branch, but I do not have the time to finish it atm. So you are very welcome to work on this issue, either building on top of that branch or starting from scratch.

So I think of this feature as a CLI flag that you can pass the path to a gitignore style file, then we would use something like file globbing or a simple version of globbing to discover the files we have to skip. I would like to filter out the files as early as possible in the process so that it has as little impact on the code as possible.

Please let me know when you start working on that (feel free to open a "work in progress" pull request for example) so that we won't do any duplicate work.

Thanks for using and contributing to R.swift!

@shiraji
Copy link
Contributor

shiraji commented Oct 18, 2016

Thanks! Actually, I have already started working on this but yours seems better. I will use your commit to complete this issue. However, feel free to finish up yours if i am too slow to do this.

@mac-cain13
Copy link
Owner Author

This is merged to master and will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants