Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force increasing permissions on dry-run #140

Closed
athossampayo opened this issue Oct 4, 2023 · 3 comments
Closed

Add option to force increasing permissions on dry-run #140

athossampayo opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@athossampayo
Copy link

athossampayo commented Oct 4, 2023

Is your feature request related to a problem?

When running the dry-run, I noticed it got an output of ~10GB(forgot to screenshot) and after running, it reported cleaning 99GB.
image

Additional Context

What I noticed is that the only difference on the runs is that the actual run asked for my password, so I got investigating the code a bit and this bit of code seems to be the "problem"/masking the difference:

                except (PermissionError, FileNotFoundError):
                    continue

What do you think of adding a option to force it to get all the permissions for dry-run too?

Also great work on this project! Simple and effective ❤️

@athossampayo athossampayo added the enhancement New feature or request label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

👋🏻 Thank you for your feedback, gonna watch it soon

@efa2d19
Copy link
Member

efa2d19 commented Oct 6, 2023

Hey 👋🏻
I'll try to improve it, but on the first look it doesn't seems to be possible.
If you have a solution tho, you are welcome to fix this 😉

@efa2d19
Copy link
Member

efa2d19 commented Nov 25, 2023

@athossampayo
I looked a bit into the issue, there is no way to increase privileges of python script mid run.
But you can always run it with sudo and problem will go away.
I'll close the issue for now but you are welcome to reopen it if problem persists with sudo

@efa2d19 efa2d19 closed this as completed Nov 25, 2023
@efa2d19 efa2d19 added the wontfix This will not be worked on label Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants