Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SwipeCard reusable? #123

Open
disczteam opened this issue Feb 2, 2021 · 1 comment
Open

Make SwipeCard reusable? #123

disczteam opened this issue Feb 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@disczteam
Copy link

Feels wasteful to have to recreate the views every time in cardForIndexAt. It would be super awesome to see card view reuse if possible!!

Loving everything else!

@disczteam disczteam added the enhancement New feature or request label Feb 2, 2021
@mac-gallagher
Copy link
Owner

Thanks for the suggestion @disczteam. Are you seeing any performance issues? This would be a nice feature, however I do not really see the need for it.

For UITableView, we need cell reuse to maintain 60fps while scrolling. In the case of this library, we only ever have 2 cards on screen, so it seems like a wasted effort since we are at 60 fps most times anyways. The one potential spot for improvement is right after a card is swiped; there is currently a small delay at this point and card reuse could possibly reduce the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant