Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling "Update Later" presents UI issue when the requiredInstallationDate is within the hour #475

Open
wegotoeleven opened this issue Apr 11, 2023 · 2 comments

Comments

@wegotoeleven
Copy link

An issue has been observed when disabling the Update Later button; the dropdown list is not visible when there is less than an hour before the installDate.

The below screenshot looks like nothing is wrong, but upon clicking the dropdown, nothing appears. Which makes sense; we’ve:

  • Disabled “Update Later”
  • It's within 72 hours, so the "Custom" option isn't available
  • Both “One hour” and “One Day” have passed

Untitled

To reproduce:

  1. Install Nudge (at leasy 1.1.11) and apply basic configuration
  2. Set allowLaterDeferralButton to false within the configuration
  3. An hour before the requiredInstallationDate, attempt to click the Defer dropdown
@erikng
Copy link
Member

erikng commented Apr 11, 2023

Sounds like the only option is to not allow any deferral UI in this state then since you disabled that key. Do you disagree?

@wegotoeleven
Copy link
Author

I agree with that sentiment. Removing the deferral drop-down menu altogether when Nudge is within the final hour should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants