Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of remote json/files - failures, log events, retries, caching #563

Open
erikng opened this issue Mar 13, 2024 · 2 comments

Comments

@erikng
Copy link
Member

erikng commented Mar 13, 2024

When using a remote JSON, the network can be unavailable, causing failures.

A quick fix was created for #561 to stop resetting Nudge when in this state.

In the future, it may be ideal to have the following

  • A new key cacheRemoteFiles for the JSON, icons and screenshots. With the newer SwiftUI features, we can gain some of this for free and use it as a fall-back if the admin desires
  • The log events may incorrectly say Current operating system (14.3.1) is greater than or equal to required operating system (0.0) if the admin does not cache. It could be argued that this is the correct behavior, but perhaps we can attempt to read any User key previously written and use that with a different log. Perhaps Current operating system (14.3.1) and the last known required operating system is (x.x).
    • We still do not want to apply a nudge event here because all of the other keys will be missing and Nudge will be unable to infer the "correct" behavior
  • retry logic should be added, perhaps with a configurable amount of seconds so Nudge can attempt to recover before fully exiting.
@erikng
Copy link
Member Author

erikng commented May 31, 2024

This is important I think for when people are using the SOFA feature. I need to test this some more.

@erikng
Copy link
Member Author

erikng commented Jul 2, 2024

I need help testing https://github.com/macadmins/nudge/releases/tag/v2.0.0.81674 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

1 participant