Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination error #57

Closed
jcfrt opened this issue Nov 21, 2022 · 1 comment
Closed

Pagination error #57

jcfrt opened this issue Nov 21, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jcfrt
Copy link

jcfrt commented Nov 21, 2022

While testing the dev branch I noticed a problem with pagination: the starting_after parameter keeps increasing, but never resets back to 0 which leads to incomplete data being returned after subsequent calls to that same method.

That is due to the fact that a python dictionary is defined as the default parameter in the _get_data method.
This is not a good practice (example reference) and should be set to None instead.

@jcfrt jcfrt mentioned this issue Nov 21, 2022
@MagerValp
Copy link
Collaborator

MagerValp commented Nov 24, 2022

Fixed in #58 and #59

@MagerValp MagerValp self-assigned this Nov 24, 2022
@MagerValp MagerValp added the bug Something isn't working label Nov 24, 2022
@MagerValp MagerValp mentioned this issue Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants