fix(editor): render nothing for recursive instances (fix #130)

uimix-editor · Jun 30, 2022 · 531223d · 531223d · vercel · Jun 30, 2022
1 parent 24c9285
commit 531223d
Showing 1 changed file with 18 additions and 13 deletions.
diff --git a/packages/editor/src/mount/ElementMount.ts b/packages/editor/src/mount/ElementMount.ts
@@ -229,20 +229,25 @@ export class ElementMount {
     this.attachedMount?.dispose();
     this.attachedMount = undefined;
 
-    if (component) {
-      this.attachedMount = new RootElementMount(
-        component,
-        component?.defaultVariant,
-        {
-          ...this.context,
-          boundingBoxUpdateScheduler: undefined,
-          registry: undefined,
-          topLevelVariant:
-            this.context.topLevelVariant ?? this.instance.variant,
-        },
-        this.dom as HTMLElement
-      );
+    if (!component) {
+      return;
+    }
+    if (component === this.instance.element.component) {
+      console.warn("Cannot render component recursively");
+      return;
     }
+
+    this.attachedMount = new RootElementMount(
+      component,
+      component?.defaultVariant,
+      {
+        ...this.context,
+        boundingBoxUpdateScheduler: undefined,
+        registry: undefined,
+        topLevelVariant: this.context.topLevelVariant ?? this.instance.variant,
+      },
+      this.dom as HTMLElement
+    );
   }
 
   private isDisposed = false;