Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring error pages #1205

Open
ldevernay opened this issue Sep 20, 2022 · 6 comments
Open

Monitoring error pages #1205

ldevernay opened this issue Sep 20, 2022 · 6 comments
Milestone

Comments

@ldevernay
Copy link

Hi,
As of today, it is difficult to monitor 404 error pages because they are handled as errors, which prevents metrics from being gathered and some best practices from being checked.
However, it could be really interesting to monitor error pages, as stated in this article from Matt Hobbs : https://nooshu.com/blog/2020/08/25/you-should-be-testing-your-404-pages-web-performance/

Do you think it would be possible?

@macbre macbre added this to the v2.4 milestone Sep 20, 2022
@macbre
Copy link
Owner

macbre commented Sep 20, 2022

@ldevernay, great idea!

@macbre
Copy link
Owner

macbre commented Sep 20, 2022

@ldevernay, how does a command line option --validate-all-response-codes sounds to you? It will cause all metrics to be returned instead of returning an error due to non-200 response code.

I'm open for discussing the naming here ;)


Inspired a bit by axios/axios#41 and https://axios-http.com/docs/handling_errors.

@ldevernay
Copy link
Author

Hi @macbre,
Thanks for this quick and thorough answer!
I will check with the rest of the team and let you know but this sounds great.

@ldevernay
Copy link
Author

ldevernay commented Sep 22, 2022

OK, that was fast : as soon as you implement this option, I confirm that we can use this on our side and it might solve our issue with 404 pages (and apparently other error pages as well).
Regarding the naming for the option, I get your point but can't find anything better for now. I think --validate-all-response-codes is clear enough.

@macbre
Copy link
Owner

macbre commented Sep 22, 2022

Great! Will work on that.

Similar: #809 and #823

@ldevernay
Copy link
Author

Awesome, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants