Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run formatters in nodejs runner #186

Closed
5 tasks done
macbre opened this issue Dec 23, 2013 · 1 comment
Closed
5 tasks done

Run formatters in nodejs runner #186

macbre opened this issue Dec 23, 2013 · 1 comment
Assignees
Milestone

Comments

@macbre
Copy link
Owner

macbre commented Dec 23, 2013

Instead of running results formatter in PhantomJS scope, run them on JSON results returned by PhantomJS "inner" script.

Needed for #10 and #12

--format is now an alias of --reporter (-R shortcut)

Subtasks

  • move formatters "framework" to nodejs runner script
  • migrate JSON reporter
  • migrate TAP reporter
  • migrate CSV reporter (using csv-string)
  • migrate plain reporter
@kennydee
Copy link
Contributor

Hi, This sounds awesome.
I test this for a few days now, but got some issue, probably due to our statsd/graphite implementation ...
Some of the graphite node comes randomly (only the upper for exemple), and metrics for some measures never show ... Phantomas seems to send them well, so that's why i think the issue is on our part. I keep digging on it. If anybody has similar issue, don't hesitate to tell me ;)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants