Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling Issue #36

Closed
saulshanabrook opened this issue Jun 30, 2014 · 9 comments
Closed

Scrolling Issue #36

saulshanabrook opened this issue Jun 30, 2014 · 9 comments

Comments

@saulshanabrook
Copy link

When I scroll down, I have two problems. The first is that the panels become out of sync when I go past long wrapped lines of source code. The second is that when I scroll down near the GIF files, it resets and jumps back up.
untitled 4

@uranusjr uranusjr added the bug label Jul 1, 2014
@uranusjr
Copy link
Member

uranusjr commented Jul 2, 2014

Hi, I tried a couple GIFs I have and some others found on the Internet, but was not able to replicate this. Would it be possible that you send me a copy of the GIF file in question (or any file that can reproduce the problem) so that I can test against it? Thanks.

@saulshanabrook
Copy link
Author

Sure
https://gist.github.com/saulshanabrook/1156f0937e6ddcd96d03#file-readme-md

On Wed, Jul 2, 2014 at 4:52 AM, Tzu-ping Chung notifications@github.com
wrote:

Hi, I tried a couple GIFs I have and some others found on the Internet,
but was not able to replicate this. Would it be possible that you send me a
copy of the GIF file in question (or any file that can reproduce the
problem) so that I can test against it? Thanks.


Reply to this email directly or view it on GitHub
#36 (comment).

Saul Shanabrook
about.me/shanabrook
[image: Saul Shanabrook on about.me]
http://about.me/shanabrook

@aaronraimist
Copy link
Contributor

I can't reproduce the GIF issue in MacDown 0.1.2 (200) on 10.9.3. Whoops. I think I was just scrolling too slow or too quickly. I can reproduce it only a certain speeds.

@saulshanabrook
Copy link
Author

I am running 10.9.4 and MacDown 0.1.2 (200). I also get the problem when I
scroll up through the gifs, it send me back down

On Wed, Jul 2, 2014 at 11:56 AM, Aaron Raimist notifications@github.com
wrote:

I can't reproduce the GIF issue in MacDown 0.1.2 (200) on 10.9.3.


Reply to this email directly or view it on GitHub
#36 (comment).

Saul Shanabrook
about.me/shanabrook
[image: Saul Shanabrook on about.me]
http://about.me/shanabrook

@uranusjr
Copy link
Member

uranusjr commented Jul 4, 2014

Just did some testing with the provided document and some slightly modified input. The issue actually has nothing to do with GIFs; I can reproduce it even after removing all image links in the document. It seems like that the problem is in the syntax highlighter—scrolling works after I turned it off (in the code; there’s no such option in the app currently). I’ll try to correct that.

@uranusjr
Copy link
Member

uranusjr commented Jul 4, 2014

I just released an dev build that should fix this problem, but since this is pretty difficult to reproduce I’m not entirely sure there are not other problems. Could you test the build and see if that works as expected? Thanks.

@saulshanabrook saulshanabrook changed the title GIF Scrolling Issue Scrolling Issue Jul 5, 2014
@saulshanabrook
Copy link
Author

@uranusjr yep it works great now! Thanks so much. However, it still doesn't always stay in sync. As you can see:
screen shot 2014-07-04 at 10 41 10 pm

What part of the text is it supposed to keep aligned with the preview? The last line?

@uranusjr
Copy link
Member

uranusjr commented Jul 5, 2014

Yeah, that’s covered by #21, as you know. Personally I’m just waiting for Hoedown to add support to source map querying (hoedown/hoedown#22) so that I can know the positional relationship between the source and rendered HTML. That can provide a way to so many cool features. But for now this is the best result possible. :(

I’ll close this later if nothing else comes up.

@saulshanabrook
Copy link
Author

Thanks for your time, this is an awesome project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants