New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't exceptions in stages be swallowed and marking the job as failed? #16

Open

ricardperez opened this issue Oct 23, 2019 · 0 comments

ricardperez commented Oct 23, 2019

pipelineUnit/pipelineTests/groovy/testSupport/PipelineTestHelper.groovy

Line 161 in 0dcd54f

throw e

I think instead of raising the exception it should be swallowed and setting the build status to failed:

...
catch (Exception e) {
    // Some sort of error in the pipeline
    binding.getVariable('currentBuild').result = 'FAILURE'
}
...

Probably somewhere else as well?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment