Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Python) Inconsistency in _randomized_dpca docstring and transform/inverse_transform #18

Closed
cboulay opened this issue Dec 10, 2017 · 2 comments

Comments

@cboulay
Copy link
Contributor

cboulay commented Dec 10, 2017

The doctstring for _randomized_dpca says that it returns P, encoding matrices used to transform data, and D, decoding matrices used to inverse transform data.

However, the actual implementation of transform(X) uses D and the implementation of inverse_transform uses P.

@cboulay
Copy link
Contributor Author

cboulay commented Dec 10, 2017

The matlab code to get P and D is similar to the Python code and, eventually (D --> decoder --> W; P --> encoder --> V), D is used for decoding and P is used for encoding, just as in the Python code. Therefore, I'm pretty sure that it's just a mistake in the docstring, but this would be a major problem if it was the code that was mistaken so I'd like confirmation either way.

Thank you,
-Chad

@wielandbrendel
Copy link
Collaborator

I can confirm it's just the wrong docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants