Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI to upload assets shows plural labels when singular is required #56

Closed
ckadner opened this issue May 26, 2021 · 4 comments · Fixed by #81 or #84
Closed

UI to upload assets shows plural labels when singular is required #56

ckadner opened this issue May 26, 2021 · 4 comments · Fixed by #81 or #84
Assignees
@drewbutlerbb4
Labels
bug Something isn't working

Comments

@ckadner
Copy link
Member

ckadner commented May 26, 2021 •
edited

Enter ... create a new models

Models name

MLX upload Models

same for the other asset upload pages
@ckadner ckadner added the bug Something isn't working label May 26, 2021
@ckadner
Copy link
Member Author

ckadner commented May 26, 2021

thanks @ptitzler for finding this

@ckadner
Copy link
Member Author

ckadner commented May 28, 2021

@drewbutlerbb4 -- can you give this one a shake as well? Thanks.

@drewbutlerbb4 drewbutlerbb4 mentioned this issue Jun 7, 2021
Merged
@ptitzler
Copy link

ptitzler commented Jun 7, 2021

The PR does not address the issue in the label text:

image

https://github.com/drewbutlerbb4/mlx/blob/4c229c82330082717b603c35000afe050c6f2884/dashboard/origin-mlx/src/pages/UploadPage.tsx#L144

@ptitzler ptitzler reopened this Jun 7, 2021
@drewbutlerbb4
Copy link
Contributor

Thanks @ptitzler didn't catch that. I'll append the change to my next PR

@drewbutlerbb4 drewbutlerbb4 mentioned this issue Jun 9, 2021
Merged
@ckadner ckadner mentioned this issue Jul 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewbutlerbb4 drewbutlerbb4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update wording and fix initial artifact setting
Cleanup react routing and update upload page wording
3 participants
@ckadner @ptitzler @drewbutlerbb4