Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor script for both Windows and Linux using Node 8 LTS and Node 10 LTS #125

Merged
merged 12 commits into from Oct 30, 2018

Conversation

LSBOSS
Copy link
Contributor

@LSBOSS LSBOSS commented Oct 29, 2018

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR adds support for building Kalimdor.JS via Appveyor for both Windows and Linux.

  • What is the current behavior? (You can also link to an open issue here)
    Kalimdor.JS is currently build via Travis for Linux only.
    See Issue here: Investigate using Appveyor for CI instead of Travis #87

  • What is the new behavior (if this is a feature change)?
    Building and testing via Appveyor

  • Other information:

  • In order to enable your build for Appveyor, you need an Appveyor account and add Kalimdor.JS as project. Then it will run on commits on every branch.
  • After adding Kalimdor.JS to Appveyor you'll find the URLs for the building badges to be included in README.md under Projects --> kalimdorjs --> Settings --> Badges
  • Building the docker image during integration test is disabled for Windows for now because by default Docker for Windows which is pre-installed on Apveyor's machines is only accepting Windows container.

@JasonShin
Copy link
Member

This is perfect @LSBOSS, thank you so much! I will make sure to include the Appveyor badge soon

@JasonShin
Copy link
Member

I'm not sure why other checks are still in Waiting for status to be reported status; I've already removed Codacy and DeepScan..

@JasonShin JasonShin self-assigned this Oct 30, 2018
@JasonShin JasonShin self-requested a review October 30, 2018 03:21
@JasonShin JasonShin assigned LSBOSS and unassigned JasonShin Oct 30, 2018
@JasonShin JasonShin added the enhancement New feature or request label Oct 30, 2018
@JasonShin
Copy link
Member

I will also merge this into V2 branch

@JasonShin JasonShin merged commit 37b6b41 into machinelearnjs:develop Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants