Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/decomposition pca #24

Merged
merged 8 commits into from Jul 14, 2018
Merged

Feature/decomposition pca #24

merged 8 commits into from Jul 14, 2018

Conversation

JasonShin
Copy link
Member

@JasonShin JasonShin commented Jul 14, 2018

adding PCA API
References:

This implementation does not factor in n_components

1. extension subtract method for matrices subtraction
2. wip: pca
1. PCA implemented; using numeric.js and compute-covariance
1. PCA documentation added
1. pca tests
2. exception tests
1. adding tests for pca
2. lint fix
@devjiro76
Copy link
Contributor

confirmed.
Thanks Jason.

@devjiro76 devjiro76 closed this Jul 14, 2018
@JasonShin JasonShin reopened this Jul 14, 2018
1. removing unncessary modules
@JasonShin
Copy link
Member Author

Also removing some unnecessary NPM Modules

@devjiro76
Copy link
Contributor

checked well.
always feel heavy thanks for your dedicate work for this.

@devjiro76 devjiro76 closed this Jul 14, 2018
@JasonShin JasonShin reopened this Jul 14, 2018
@JasonShin
Copy link
Member Author

fix the failing test

1. removing ml-euclidean-distance depedency
2. fixing the unit tests
1. removing load() function from nighbors/classification.ts
@JasonShin JasonShin merged commit a436b29 into master Jul 14, 2018
@JasonShin JasonShin deleted the feature/decomposition-pca branch July 15, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants