-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails with latest ember-decorators and Ember canary #38
Comments
Technically I tried quick fixing it, but it's not as easy, especially since ember-concurrency itself does not work with Ember 3.9 just yet: machty/ember-concurrency#277 My recommendation so far is: Stick to Also do not upgrade to Ember 3.9 canary yet. If you need to use a canary, because of feature flags, use that latest 3.8 canary. :) |
Much appreciated! 😍
Will do so, thanks!
Fwiw, I was using an earlier 3.9 canary build before, which was working. But I guess this didn't include the mentioned Descriptor changes yet, so will revert to that build... |
I've published It does however not yet support canary, because ember-concurrency and @ember-decorators itself don't support it yet. So I'll keep this open. |
Fixed in |
Given
ember-concurrency-decorators@0.5.3
ember-decorators@5.1.3
ember-source@canary
(latest build)I get a
Uncaught TypeError: Cannot read property 'writable' of undefined
exception. The stack trace shows:computedDecorator
callingfn
without args herefn
being this callback here, which expects a descriptor as its argument, which is not there (undefined
)This came up after upgrading to the latest ember canary, and then upgrading
ember-decorators
to the latest release to fix some other issue there. So apparently related to ember-decorators/ember-decorators#398, which introduced a different implementation ofcomputedDecorator
for Ember 3.9.0 (see the implementations separated bygte('3.9.0')
) .But I guess ember-decorators is not to blame here, as
computedDecorator
is undocumented and seems to be a private API, right?/cc @buschtoens @pzuraq
The text was updated successfully, but these errors were encountered: