Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in BPR loss function #185

Open
PeterZaidel opened this issue Jan 22, 2021 · 0 comments
Open

Error in BPR loss function #185

PeterZaidel opened this issue Jan 22, 2021 · 0 comments

Comments

@PeterZaidel
Copy link

Hello! Thank you for your great work!
In your realisation of bpr loss you use the following formula:

loss = (1.0 - torch.sigmoid(positive_predictions - negative_predictions)).

In the original publication (bpr paper) the authors propose
loss = log(sigmoid(positive - negative)) + regularisation.
Is it okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant