-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
September 2022 Update #3
Conversation
✅ Deploy Preview for spotify-playlist-archive ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hmm... that's odd. Something went wrong while creating a production build, and it appears to have something to do with the charts library. Give me a sec. |
I've resolved the issue. The preview link is above! |
The "Export to JSON" button looks and works great! Were you also planning on adding a "Copy playlist URLs" button? I think it'd be really useful for non-technical folks who want to re-create old versions of their favorite playlists (see my original comment on mackorone/spotify-playlist-archive#134) |
Yeah, it should be right next to the Export button... but if you couldn't see it, I believe I know why. Give me a minute and I'll push an update. Also, there's the Get playlist ID from URL page too, so feel free to check it out as well! |
@mackorone so previously I showed the copy button only if the browser supported the Clipboard API and permission to write to clipboard was granted. Now instead of hiding the button, the site just disables it and places an info icon to its left. When hovered over, it explains why you can't use the feature. |
Ah, got it. Thanks for clarifying. I just tested the "Copy track URLs" button with a browser that supports it - it works great! That said, I wonder if there's something we can do for the other browsers... perhaps in that case, the button can instead just open a page containing only the URLs, so that the user can select them manually? Something like GitHub's "Raw" button that displays when browsing files?
Just played around with this - works great! |
That's a great idea! Funnily enough, I implemented something similar for the Get playlist's ID page, where the copy button falls back to showing the ID for user to copy manually. |
Yo @mackorone, right when I was about to push the commit with fallback dialog for copying track URLs, I realised I had 5 minutes to catch my bus to school. I didn't miss it in the end, but I didn't push the changes, so you will have to wait 7 or so hours before I get back home |
Hey @mackorone, sorry about the seven-hour wait! I've just come back home and pushed all commits. Now if you want to copy a snapshot's track URLs, but the clipboard is unavailable, an appropriate dialog will show up. |
Looks great! |
Gotcha! I'm on my way home as we speak, will let you know once I've merged the PR and all the changes are live. |
@mackorone, Netlify should create a preview deploy in a minute. Could you take a look and see if I should tweak anything?