Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

September 2022 Update #3

Merged
merged 13 commits into from
Sep 7, 2022
Merged

September 2022 Update #3

merged 13 commits into from
Sep 7, 2022

Conversation

maciejpedzich
Copy link
Owner

@mackorone, Netlify should create a preview deploy in a minute. Could you take a look and see if I should tweak anything?

@netlify
Copy link

netlify bot commented Sep 3, 2022

Deploy Preview for spotify-playlist-archive ready!

Name Link
🔨 Latest commit 12ac4a6
🔍 Latest deploy log https://app.netlify.com/sites/spotify-playlist-archive/deploys/6315e00feb25e7000920496e
😎 Deploy Preview https://deploy-preview-3--spotify-playlist-archive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maciejpedzich
Copy link
Owner Author

@mackorone, Netlify should create a preview deploy in a minute. Could you take a look and see if I should tweak anything?

Hmm... that's odd. Something went wrong while creating a production build, and it appears to have something to do with the charts library. Give me a sec.

@maciejpedzich
Copy link
Owner Author

@mackorone, Netlify should create a preview deploy in a minute. Could you take a look and see if I should tweak anything?

Hmm... that's odd. Something went wrong while creating a production build, and it appears to have something to do with the charts library. Give me a sec.

I've resolved the issue. The preview link is above!

@mackorone
Copy link

if I should tweak anything

The "Export to JSON" button looks and works great! Were you also planning on adding a "Copy playlist URLs" button? I think it'd be really useful for non-technical folks who want to re-create old versions of their favorite playlists (see my original comment on mackorone/spotify-playlist-archive#134)

@maciejpedzich
Copy link
Owner Author

if I should tweak anything

Were you also planning on adding a "Copy playlist URLs" button?

Yeah, it should be right next to the Export button... but if you couldn't see it, I believe I know why. Give me a minute and I'll push an update. Also, there's the Get playlist ID from URL page too, so feel free to check it out as well!

@maciejpedzich
Copy link
Owner Author

@mackorone so previously I showed the copy button only if the browser supported the Clipboard API and permission to write to clipboard was granted. Now instead of hiding the button, the site just disables it and places an info icon to its left. When hovered over, it explains why you can't use the feature.

If the Clipboard API is not supported:
Clipboard API unsupported popup

If writing to clipboard is not allowed:
Writing to clipboard is not allowed popup

@mackorone
Copy link

the site just disables it and places an info icon to its left

Ah, got it. Thanks for clarifying. I just tested the "Copy track URLs" button with a browser that supports it - it works great! That said, I wonder if there's something we can do for the other browsers... perhaps in that case, the button can instead just open a page containing only the URLs, so that the user can select them manually? Something like GitHub's "Raw" button that displays when browsing files?

Also, there's the Get playlist ID from URL page too

Just played around with this - works great!

@maciejpedzich
Copy link
Owner Author

I wonder if there's something we can do for the other browsers... perhaps in that case, the button can instead just open a page containing only the URLs, so that the user can select them manually? Something like GitHub's "Raw" button that displays when browsing files?

That's a great idea! Funnily enough, I implemented something similar for the Get playlist's ID page, where the copy button falls back to showing the ID for user to copy manually.

image

@maciejpedzich
Copy link
Owner Author

Yo @mackorone, right when I was about to push the commit with fallback dialog for copying track URLs, I realised I had 5 minutes to catch my bus to school. I didn't miss it in the end, but I didn't push the changes, so you will have to wait 7 or so hours before I get back home

@maciejpedzich
Copy link
Owner Author

Hey @mackorone, sorry about the seven-hour wait! I've just come back home and pushed all commits. Now if you want to copy a snapshot's track URLs, but the clipboard is unavailable, an appropriate dialog will show up.

Dialog with track URLs to copy

@mackorone
Copy link

Looks great!

@maciejpedzich
Copy link
Owner Author

Looks great!

Gotcha! I'm on my way home as we speak, will let you know once I've merged the PR and all the changes are live.

@maciejpedzich maciejpedzich merged commit 1b2d55b into master Sep 7, 2022
@maciejpedzich maciejpedzich deleted the september-2022-update branch September 7, 2022 16:15
@maciejpedzich maciejpedzich mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants