Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce back external module #150

Open
maciejtreder opened this issue Mar 26, 2018 · 4 comments
Open

introduce back external module #150

maciejtreder opened this issue Mar 26, 2018 · 4 comments
Assignees
Labels
comp: init Init Package P2: medium Improvements and non-critical bugfixes type: enhancement Iterations on existing features or infrastructure

Comments

@maciejtreder
Copy link
Owner

I'm submitting a...


[ x ] Bug report  
[ x ] Feature request
[ ] Documentation issue or request

Current behavior

Lack of support for external modules

Expected behavior

After upgrade to CLI (#144) external module support must be fixed

@maciejtreder maciejtreder self-assigned this Mar 26, 2018
@maciejtreder maciejtreder added type: bug Issues that break the functionality P2: medium Improvements and non-critical bugfixes labels Mar 26, 2018
@cgatian
Copy link

cgatian commented Apr 12, 2018

I dont recall what external module support was? You briefly talk about it in the README but could you explain a little deeper?

@maciejtreder
Copy link
Owner Author

Sure.

In previous versions (when this boilerplate was based on webpack, not CLI) there was a possibility to import external module, written in separate repository, and lazy-load it as a part of the application.

I have done it, as a somekind of 'microservices' structure support. Developer could create services in separated repos with following manner:

  • my_service_1/api
  • my_service_1/ui

then, those /ui part could be installed as a dependency for main application, and included into routing.

Of course, when you are attaching new module, you need to recompile whole app (because of new routing in the main app). But I would like to implement mechanism (so far I don't know how :D ), which could add possibility to simply replace file with external module chunk, when there is such need.

So far, after updating to CLI, I ran into issue with JIT compilation - so decided to remove external module support for now, and bring it back in the future

@selipso
Copy link

selipso commented May 9, 2018

Not sure if this helps but the new CLI's ng generate library combined with ng add commands might help solve this issue for Angular v6.

@maciejtreder maciejtreder added the comp: init Init Package label May 15, 2018
@maciejtreder
Copy link
Owner Author

@selipso Thank you for this comment. I will check if ng generate library gives us a chance here.

@maciejtreder maciejtreder added type: enhancement Iterations on existing features or infrastructure and removed type: bug Issues that break the functionality labels Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: init Init Package P2: medium Improvements and non-critical bugfixes type: enhancement Iterations on existing features or infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants