Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed scroll on desktop #51

Closed
wants to merge 1 commit into from
Closed

fixed scroll on desktop #51

wants to merge 1 commit into from

Conversation

lillian-kodi
Copy link
Contributor

Scrolling was always possible on desktop but the scroll bar was set to width: 0 rendering it imperceptible

@vercel
Copy link

vercel bot commented Sep 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/macjabeth/showbunny/5qN2Fkk5VJu7VggcqsK325ApMWTt
✅ Preview: https://showbunny-git-fork-lillian-kodi-feature-issue-49-macjabeth.vercel.app

@macjabeth
Copy link
Owner

Hi @lillian-kodi - thanks for submitting the PR! The scrolling width of 0 was actually set intentionally.

My goal was to get rid of the horizontal scrollbar and instead have buttons which the user can click to scroll forward and back on desktop.

Screen Shot 2021-09-13 at 11 26 46 PM

Whether the buttons are above the media posters as depicted in the design above, or put as a hover element towards the beginning and end of the list similar to Disney+ or Hulu, either is fine.

Screen Shot 2021-09-13 at 11 45 59 PM

Screen Shot 2021-09-13 at 11 46 45 PM

If you'd like to try your hand at implementing this feature, that would be most welcome! 🙂

@macjabeth macjabeth linked an issue Sep 14, 2021 that may be closed by this pull request
@lillian-kodi
Copy link
Contributor Author

Okay, I understand. Yes, I would love to take on this problem. Please may I have this task assigned to me?

@lillian-kodi lillian-kodi closed this by deleting the head repository Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop view cannot scroll through the lists
2 participants