Added alternative names for fn describe and fn it
#27
Conversation
regexident
force-pushed
the
given-when-then
branch
from
6127ae8
to
61e6551
Compare
| @@ -111,6 +111,46 @@ impl<'a> Context<'a> { | |||
| self.tests.push(Testable::Describe(String::from(name), child)) | |||
| } | |||
|
|
|||
| /// Interchangeable alternative name for [`describe`](struct.Context.html#method.describe). | |||
| /// | |||
| /// See [`describe`](struct.Context.html#method.describe) for more info. | |||
| #[test] | ||
| fn it_can_call_when_inside_describe_body() { | ||
| describe("A Root", |ctx| ctx.when("nested describe", |_ctx| {})); | ||
| } |
There was a problem hiding this comment.
missing tests for context and specify. You may want a macro, like:
macro_rules! test_describe_alias {
($alias: ident) => {
#[test]
fn describe_has_alias_$alias() {
describe("A Root", |ctx| ctx.$alias("nested describe", |_ctx| {}));
}
}
}(made from memory, without testing, it may not compile...)
| ctx.then("nested then", || Ok(()) as Result<(),()>) | ||
| }) | ||
| }) | ||
| }); |
|
Thanks a lot ! If the PR is successfully merged, my policy is to make you a collaborator of the repository and give you the commit rights. |
regexident
force-pushed
the
given-when-then
branch
from
61e6551
to
20a3ce1
Compare
|
Sorry for the delay, Thomas. 😢
|
There was a problem hiding this comment.
Sorry for the delay, Thomas. 😢
No problem, we all have lives out there. OSS has the benefit to let us craft the code without a hurry. 😉
This is a GO for me, there is adequate documentation, examples and tests so that we'll know people will be able to use them. 👏
🎉 congrats @regexident ! 🎉 You are now a committer of if this repository !
The rules are very simple, you already know them:
- don't commit directly to master, use features branches with PR
- all code must be tested, public apis must be documented, examples should be provided when relevant
- you can merge a PR after 10 days without comments on my part. You gained my trust after all
- if someone merged a PR with code, he becomes a committer
- be kind to people
... this should be in a CONTRIBUTING.md
| @@ -19,13 +19,37 @@ | |||
| //! ctx.it("use a `ctx` object", || Ok(()) as Result<(),()>) | |||
| //! }); | |||
| //! | |||
| //! describe("Context::specify", |ctx| { | |||
| //! ctx.specify("can used as a drop-in alternative to `Context::describe`", |ctx| { | |||
There was a problem hiding this comment.
should be “can be used”, isn't it ?
| { | ||
|
|
||
| let mut child = Context::default(); | ||
| body(&mut child); | ||
| self.tests.push(Testable::Describe(String::from(name), child)) | ||
| self.tests.push(Testable::Describe(name.into(), child)) |
Attempts to fix issues #5 and #6.
I also added the popular
given->when->thenvariants while I was at it.