Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different ports shown on same page #26

Open
rajgoesout opened this issue Sep 16, 2019 · 5 comments
Open

different ports shown on same page #26

rajgoesout opened this issue Sep 16, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@rajgoesout
Copy link
Member

Builds for py-tensorflow and py-tensorflow_estimator are displayed on the same page.
http://ec2-3-17-139-39.us-east-2.compute.amazonaws.com/#/ports?id=py-tensorflow

@rajgoesout rajgoesout added the bug Something isn't working label Sep 16, 2019
@ryandesign
Copy link

At least one problem is here:

https://github.com/macports/buildbot-macports-custom-views/blob/master/src/components/PortsList.vue#L92-L95

                if (builder.name.includes('_')) {
                  return (
                    builder.name
                      .slice(0, builder.name.indexOf('_'))
                      .toLowerCase()
                      .indexOf(this.search.toLowerCase()) > -1

This assumes that a builder name is portname_platform and that portname does not contain underscores. The first assumption isn't correct for my installation because I changed the format of the builder names, and the second assumption isn't correct for ports like py-tensorflow_estimator whose names do contain underscores.

Can it access properties of the build? We set the portname build property to the name of the port.

@rajgoesout
Copy link
Member Author

This assumes that a builder name is portname_platform and that portname does not contain underscores. The first assumption isn't correct for my installation because I changed the format of the builder names, and the second assumption isn't correct for ports like py-tensorflow_estimator whose names do contain underscores.

You're right. I had assumed some weird naming conventions.

Can it access properties of the build? We set the portname build property to the name of the port.

I'm not sure whether that could be done efficiently in the frontend (I'll check and let you know), but we could assign a tag which would basically be the portname. I think we are already doing that: https://github.com/macports-gsoc/macports-buildbot/blob/master/master.cfg#L135

@ryandesign
Copy link

Yes there is a tag for the port name but there are also other tags (_virtual_ and either the macOS version or the platform for non-Darwin workers). Can you differentiate between the tags to find the one that is the port name?

@rajgoesout
Copy link
Member Author

We can assign tags in a particular order (in the buildmaster) such that the first tag (in the list of tags) is always the portname. Then it would be possible to differentiate.

@ryandesign
Copy link

If it preserves the order, then sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants