Add upx-devel #2
Conversation
| name upx-devel | ||
| version 20161019 | ||
| categories archivers | ||
| maintainers openmaintainer |
There was a problem hiding this comment.
We do not use openmaintainer on its own. If you want to maintain the port, add your domain.tld:localpart-formatted email address; otherwise, set this to nomaintainer.
| fetch.type git | ||
| post-fetch { | ||
| system -W ${worksrcpath} "git submodule update --init --recursive" | ||
| } |
There was a problem hiding this comment.
upx/upx does not seem to have any submodules, so this part is unnecessary and prevents mirroring. Please remove fetch.type git and the post-fetch block.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, right, ignore this comment then.
| } | ||
|
|
||
| post-configure { | ||
| # Ensure that the correct compiler is used |
There was a problem hiding this comment.
This comment seems misleading; you're ensuring the right flags are used, but not the right compiler.
There was a problem hiding this comment.
Sorry, copy and paste error.
| platforms darwin | ||
| checksums ${distname}${extract.suffix} \ | ||
| rmd160 205df5485c93e452c591402cc579baad785d8ffd \ | ||
| sha256 28c859898e61025f65f4985162de2a1fdaa221fd46453e7b2ea4facd7a67060e |
There was a problem hiding this comment.
When there is only one distfile, there is no need to tell checksums what file the checksums are for; it knows. In this case, since you're fetching from git, there is no distfile, so the entire checksums stanza is unnecessary. If, per @neverpanic's earlier comment, you change to not fetching from git, then you would keep (and if necessary update) the checksums.
There was a problem hiding this comment.
When I wrote this it wouldn't build without the checksums, but now it's fine. Weird.
|
|
||
| github.setup upx upx 5c0340f | ||
|
|
||
| name upx-devel |
There was a problem hiding this comment.
upx-devel probably conflicts with upx, doesn't it? If so, add conflicts upx to this port, and add conflicts upx-devel to the upx port.
| @@ -0,0 +1,44 @@ | |||
| # $Id$ | |||
There was a problem hiding this comment.
Please remove the # $Id$ line; we aren't using this anymore now that we've moved from Subversion to git. But do please add the standard modeline.
|
All fixed. |
|
Looks good to me, with the caveat that I have not tried to build it. |
|
I have. |
Ryan Schmidt identified that github.setup must be the same lower/Upper case as on github. fixes: https://trac.macports.org/ticket/55276
Patch based on upstream merge request #2. https://gitlab.gnome.org/GNOME/libgit2-glib/merge_requests/2
Update fork with recent upstream changes.
* add mingw64 build to travis CI * Make .travis-lin-mingw.sh executable * .travis-lin-mingw.sh: make build dir * show $PWD in travis-lin-mingw * update .travis-lin-mingw.sh * --- * update .travis-lin-mingw.sh * update p7zip cmd * fix sign/unsign comparioson in usb.c * revert call .travis.sh * clean up .travis-lin-mingw.sh
Revert "Update to master"
- add "yjit" variant. YJIT of ruby3.2 requires rustc >= 1.58 to build. [note] YJIT supports x86-64 and arm64/aarch64. - fix select file for man ``` $ sudo port install ruby-devel +yjit $ sudo port select --set ruby ruby32 $ git clone --depth 1 https://github.com/Shopify/yjit-bench.git $ cd ./yjit-bench $ ruby3.2 -I./harness ./benchmarks/fib.rb ruby 3.2.0dev (2022-12-03) [x86_64-darwin22] itr #1: 189ms itr #2: 194ms : $ ruby3.2 --yjit -I./harness ./benchmarks/fib.rb ruby 3.2.0dev (2022-12-03) +YJIT [x86_64-darwin22] itr #1: 40ms itr #2: 39ms : ```
This makes three changes to the patches for 10.4 and 10.5: 1) In the G3 patch, it removes the ppc7400 reference that was never actually iused, rather than updating it. It still fixes the case that is actually used. 2) It removes the patch for i386 assembler that has been (approximately) incorporated upstream since v3.4.5. The collision with this patch was the reason for the patch failure. 3) For the gcc 4.2 test-build fix, it replaces the conditionally applied patchfile with an unconditional patch controlled by an environment variable, thereby keeping the source code consistent across OS versions. This new environment variable is now defined by the Portfile when the compiler is gcc 4.2. The patches for macports#1 and macports#2 are now in a single unified patchfile. Closes: https://trac.macports.org/ticket/69380 TESTED: Tested on 10.4-10.5 ppc, 10.5-10.6 ppc (x86_64 Rosetta), 10.4-10.6 i386, 10.4-12.x x86_64, and 11.x-14.x arm64. Now builds and passes at least some tests on all tested platforms, except 10.4 ppc +universal. Test behavior on 10.6+ is essentially unchanged. Tests on 10.4 and 10.5 have a few additional failures since v3.4.4 (the last version that built successfully) due to new tests having been added.
See upx/upx#4.