Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible vulnerability on the node unique ID #4

Closed
brunoerg opened this issue Aug 18, 2019 · 2 comments
Closed

Possible vulnerability on the node unique ID #4

brunoerg opened this issue Aug 18, 2019 · 2 comments

Comments

@brunoerg
Copy link

MD5 is used on the source code to create the node unique ID, however, md5 is a vulnerable algorithm (collision attacks). To improve the security of the protocol, I suggest to change it to a secure and efficient algorithm (Blake2, for example).

@macsnoeren
Copy link
Owner

You are correct. I do a simple ID creation and MD5 will most probably not have any collisions in this particular case. This code is used for my Blockchain course, so I will not change it now. I will consider your suggestion during the new class.

@macsnoeren
Copy link
Owner

I have changed the md5 to sha512 to create the id within the new class. So less likely to have collision attacks. Thanks for your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants