Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support login_hint for createLoginURL #2

Closed
kenchan0130 opened this issue Sep 5, 2022 · 3 comments
Closed

Support login_hint for createLoginURL #2

kenchan0130 opened this issue Sep 5, 2022 · 3 comments

Comments

@kenchan0130
Copy link

OIDC login URL can have a login_hint param.
ref: https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest

If you already know the login ID, it improves the UX.

@mactroll
Copy link
Owner

mactroll commented Sep 6, 2022

🤔

Since OIDCLite doesn't actually submit the URL to an ASWebAuthentication session, or other WebView... is there much benefit to OIDCLite adding that parameter instead of having your app do it before you pass the URL on?

@kenchan0130
Copy link
Author

kenchan0130 commented Sep 7, 2022

We need to think about the responsibilities of the method before we talk about the benefits.

I think it depends on what you consider the responsibilities of OIDCLite's createLoginURL method to be.

If the method is responsible for issuing an OIDC login URL, then I think it should support the content based on the OIDC specification.

If there are no responsibilities, then my request itself should be withdrawn, as there is no obligation to absorb the specification in that method.

@kenchan0130
Copy link
Author

@mactroll
I would really appreciate it if you could respond to the question above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants