Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with life mending in apotheosis when using smaller heal values? #11

Open
Darkmega18 opened this issue Aug 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Darkmega18
Copy link

Darkmega18 commented Aug 2, 2023

I had an issue previously where life mending from apotheosis wasn't ticking properly with harder natural healing. This is probably because my health regen ticks were too small for it to pick up cause they were fractional values smaller than a half heart to slow the regeneration lower than 1 at a time.
Shadows-of-Fire/Apotheosis#930

Shadow gave an explanation of why it might not be working. and I was wondering if you'd make some changes to the system to allow it to keep track of these smaller values over time but then only pass a proper tick of half hearted healing to the player when it gets above a recorded threshold of healing that will be received, so that this enchantment will potentially work with my current setup, and anyone else who might have similar issues with it and configuring this mod to their liking.

This is for the 1.19.2 version. as thats where apotheosis is currently.

@mactso
Copy link
Owner

mactso commented Nov 16, 2023

Okay, just so you know, healing less than a half heart still adds to your total health (even down to 0.000001). The half hearts are just the gui/visual total representation of your health. So a display of 5 and a half hearts can be from 10.00001 to 10.500000 (or maybe 10.500000 to 10.599999).

The only case where it would be a problem as suggested is if the healing was too small for a float to record (so less than about 0.000001) which is like 1 millionth of a health point. The value being a float hardcoded as a float in minecraft.

The way that the hunger works is they have a second field called saturation for health. Minecraft reduces saturation first if it is greater than zero and when saturation reaches zero then minecraft starts lowering food bars.

Which Harder natural healing setting are you using? Or if you are using custom settings, what healing value are you using? Have you tried increasing it helps apothesis tick properly? Perhaps start with a large value first... then make it smaller until Apothesis stops working.

Hope this helps,
MacTso

@mactso mactso self-assigned this Nov 16, 2023
@mactso mactso added the enhancement New feature or request label Nov 16, 2023
@Darkmega18
Copy link
Author

Darkmega18 commented Nov 17, 2023

Okay, just so you know, healing less than a half heart still adds to your total health (even down to 0.000001). The half hearts are just the gui/visual total representation of your health. So a display of 5 and a half hearts can be from 10.00001 to 10.500000 (or maybe 10.500000 to 10.599999).

The only case where it would be a problem as suggested is if the healing was too small for a float to record (so less than about 0.000001) which is like 1 millionth of a health point. The value being a float hardcoded as a float in minecraft.

This I know.

The way that the hunger works is they have a second field called saturation for health. Minecraft reduces saturation first if it is greater than zero and when saturation reaches zero then minecraft starts lowering food bars.

This also.

Which Harder natural healing setting are you using? Or if you are using custom settings, what healing value are you using? Have you tried increasing it helps apothesis tick properly? Perhaps start with a large value first... then make it smaller until Apothesis stops working.

It's just a delay of around 7-10ish seconds. 0.25 health per heal tick, cause theres no way to reduce the delay between each tick, only the amount of ticks per heal. so I have to set it low like 0.25 to make it look like it's only healing a half heart every few seconds.
Apotheosis already fails to work due to it being too small, so it likely requires a value of around 1 healing (half a heart) atleast to proc.
Since healing a few hearts with some other external item or through a regeneration proc does the trick.
I have such a set up to encourage the use of bandages, healing effects/potions and regenerative campfire buffs etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants