Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do batch size come into play in the S3IM formulation #1

Closed
haiphamcse opened this issue Aug 23, 2023 · 4 comments
Closed

How do batch size come into play in the S3IM formulation #1

haiphamcse opened this issue Aug 23, 2023 · 4 comments

Comments

@haiphamcse
Copy link

Hi there, loved your work and currently trying to add it to some neural field research. I have a question about the batch size of a ray in your formulation:
1/ Suppose a batched ray size (batch, num_rays, 3). How would we construct a patch P? I'm currently iterating through each batch (num_rays, 3) batch times and averaging the results. However I noticed here that the loss varies with different batch size (more batch -> higher losses). Is this consistent with your formulation?
2/ Have you tested with other patch size other than 64x64. Does bigger patch size have any affects on perfomance?

@Madaoer
Copy link
Owner

Madaoer commented Aug 23, 2023

Hello haiphamcse

  1. We use the final rgb piexl(batch, 3) instead of intermediate rgb points(batch, num_rays, 3) to make a virtual patch. For example, (4096, 3) --> (64, 64, 3).
  2. We use 64 x 64 because in original nerf methods(DVGO, TensoRF) use 4096 as default setting. Due to the repeat time in our methods, I think s3im already have enough randomness, so a bigger patch size maybe not that helpful.

@haiphamcse
Copy link
Author

What is the right way to use S3IM if the number of rgb pixels is larger than (4096,3). Do we just change the kernel size proportionally?

@Madaoer
Copy link
Owner

Madaoer commented Aug 23, 2023

No need for increasing kernel size. For example, we can keep the virtual patch as a shape like (64, batch_size / 64 / 3, 3)

@haiphamcse
Copy link
Author

Thank you for your reply! I understand now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants