Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script runs dryrun first, only purges services on 2. run, wrong console display? #24

Closed
zoulztealer opened this issue Aug 28, 2018 · 2 comments
Labels
Bug/Error Yup it's a bug or error Fixed/Option Added The bug or Suggestion has been added and is released

Comments

@zoulztealer
Copy link

zoulztealer commented Aug 28, 2018

Describe the bug
not sure if this is intended, but there are a few things i have noticed, that were not there in the versions before.

  1. when clicked on run script, the script does a dryrun / list first even when there is no dry run option activated. only when run script is clicked another time after the first run, the script purges the services.

  2. after having purged services, the console window shows unclear categories "msg1":

>  Changing Service Please wait...
> msg1Tweaked
>  Service_Name - Current -> Change_To
> ----------------------------------------

and

> ----------------------------------------
>  Service Changed...
> msg13
> msg1161
> msg13
> msg10
> msg100:00:01.7787463

To Reproduce
Steps to reproduce the behavior:

  1. run script
  2. check console window / script behaviour

Expected behavior
the script should not dry run when its not activated. run script should cause immediate purge of services. msg1 should display correct values.

Screenshots
bvscript1
bvscript2
bvscript3
bvscript4
bvscript5

Desktop (please complete the following information):

  • OS Version: win 10 pro 64
  • OS Build: 17134.228

Additional context

  • Script Version: 5.2.1 (aug 26 2018)
  • service version: 4.0 (may 29 2018)
  • Release Type: stable
@madbomb122
Copy link
Owner

madbomb122 commented Aug 28, 2018

Thanks for letting me know,
I found the bug with that msg1 thing (simple mistake in script), it's supposed to display text instead of msg1 -Fix will be in next release

as for the dry-run.. that ran because of the dev log option. (I should put a note in there about that) -Note will be in next release.

As for the 2nd run not doing a dry run (when it should have with the dev log checked) is something i have to check into.

@madbomb122 madbomb122 added Bug/Error Yup it's a bug or error In Next Release Item will be in Next Release Fixed/Option Added The bug or Suggestion has been added and is released and removed In Next Release Item will be in Next Release labels Aug 28, 2018
@madbomb122
Copy link
Owner

Issue should be Fixed and has been release (in v5.2.2)

If issue still happens please re-open, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug/Error Yup it's a bug or error Fixed/Option Added The bug or Suggestion has been added and is released
Projects
None yet
Development

No branches or pull requests

2 participants