Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example CSS to add +egg numbers to monster thumbnails #152

Closed
davethegr8 opened this issue Jan 7, 2014 · 4 comments
Closed

Example CSS to add +egg numbers to monster thumbnails #152

davethegr8 opened this issue Jan 7, 2014 · 4 comments

Comments

@davethegr8
Copy link

I noticed that the thumbnails on the monsters don't include the total +egg numbers, so I prototyped it out. It's not perfect and the colors might need some tweaking, but this is the thumbnail link with some new css.

<a href="" style="position: relative; display: block;">
    <img src="221.cd3df10a06d7.png" style="display: block;">
    <span style="position: absolute; top: 0px; right: 0px; color: yellow; font-weight: bold; letter-spacing: -1px; text-shadow: 1px 1px 0px black;">+22</span>
</a>

It ends up looking like this:

screen shot 2014-01-06 at 4 57 48 pm

@madcowfred
Copy link
Owner

It's not hard to do, I'm just wondering why I would want to add this. The UI is already rather busy, adding extra duplicated information isn't going to help things (and more DOM elements also increases rendering time).

@davethegr8
Copy link
Author

shrug don't know. I was using the app, noticed that +'s weren't showing and it confused me since I'm so used to them. heh. Then I thought, "oh, that shouldn't be too hard" and I did it because I wanted to see how I would do it. And then I thought maybe you'd want to see it in case you hadn't planned on adding that or hadn't got around to it or whatever. Feel free to close this issue, I just wanted to share in case it was helpful. :) I really dig your app and didn't want to be a total tourist.

@madcowfred
Copy link
Owner

There's another issue (GH-105) about inconsistent monster icon display - I may make the Monsters list display total +eggs as part of that in future. Thanks for contributing, it's just a constant struggle to deal with displaying data in a reasonable way :)

@madcowfred
Copy link
Owner

Added this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants