Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vsync doesn't properly match refresh rate #17

Closed
Keith94 opened this issue Feb 3, 2019 · 5 comments
Closed

Vsync doesn't properly match refresh rate #17

Keith94 opened this issue Feb 3, 2019 · 5 comments

Comments

@Keith94
Copy link

Keith94 commented Feb 3, 2019

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings
  2. Set Vsync to Enabled
  3. Set refresh rate to 120 Hz

Expected behavior
Vsync should cap the frame rate to refresh rate correctly.

Actual behavior
Vsync caps the frame rate at 60 FPS (half the refresh rate)

Screenshots
rbdoom3bfg_2017_08_11_11_17_30_602

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 73

Additional context

@MadDeCoDeR
Copy link
Owner

Vsync in opengl works as follows: if it is on then it cap the framerate based on monitor refresh rate, if is set to smart (adaptive) then the vsync is closing if the framerate is lower than the monitor's refresh rate.
I hope this clear some things out here.

@MadDeCoDeR
Copy link
Owner

I updated it, and now the framerate is using the monitor refresh rates instead of the original two static values. Hope that makes it better than before

@Keith94
Copy link
Author

Keith94 commented Apr 16, 2020

This seems like an improvement. Now I assume someone with a 144 Hz monitor could select it via the "Frame Rate" option.

  1. Since it is using the refresh rate, should you rename the option to "Refresh Rate" ?

  2. What if someone wanted to set the refresh rate or frame rate limit indecently? Can it be done from the config file?

@MadDeCoDeR
Copy link
Owner

The refresh rate and the frame rate are both now a singular cvar. I won't change the name since it still have the same meaning, and sadly you can't set them up indepenently.

@Keith94
Copy link
Author

Keith94 commented Apr 16, 2020

Okay! Thanks

@Keith94 Keith94 closed this as completed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants