Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for WooCommerce 3.x #5

Closed
paulmiller3000 opened this issue Nov 3, 2019 · 6 comments
Closed

Update for WooCommerce 3.x #5

paulmiller3000 opened this issue Nov 3, 2019 · 6 comments

Comments

@paulmiller3000
Copy link
Contributor

Would you be willing to open this up for branches and pull requests? I made a small change to support WooCommerce 3.x and would like to open a pull request.

Thanks!

@maddisondesigns
Copy link
Owner

Hi Paul.

Definitely! Feel free to make a pull request if you've improved it. That'd be great! Thanks :-)

@paulmiller3000
Copy link
Contributor Author

paulmiller3000 commented Nov 4, 2019

Awesome! Would you please update security settings so I can push a branch? Currently receiving a 403:

$ git push --set-upstream origin update_for_woocommerce_3x
remote: Permission to maddisondesigns/woocommerce-software-license-manager.git denied to paulmiller3000. fatal: unable to access 'https://github.com/maddisondesigns/woocommerce-software-license-manager.git/': The requested URL returned error: 403

@maddisondesigns
Copy link
Owner

If you submit a pull request, I can merge it for you.

@paulmiller3000
Copy link
Contributor Author

Just learned I could pull request across forks. Very cool! PR submitted.

@maddisondesigns
Copy link
Owner

Thanks very much for that. I've just merged that PR.

@paulmiller3000
Copy link
Contributor Author

Awesome, glad I could help. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants