Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use FlagKit in Objective-C project #57

Closed
edwardmp opened this issue Dec 11, 2017 · 5 comments
Closed

Can't use FlagKit in Objective-C project #57

edwardmp opened this issue Dec 11, 2017 · 5 comments

Comments

@edwardmp
Copy link
Contributor

Hi,

Maybe there's something else going on here, but somehow I can't use FlagKit anymore in my Objective-C project.

Using [[FKFlag alloc] initWithCountryCode:@"FLAGKIT"]
leads to a compiler error claiming that FKFlag does not have any initWithCountryCode initializer.

Is anyone else experiencing the same issue?

@blommegard
Copy link
Member

Hi!

Do you use Cocoapods or Carthage? Would you mind trying out the master branch before I make a release?

@edwardmp
Copy link
Contributor Author

CocoaPods. I see your commits, might indeed be related to Swift 4 compatibility. Will check out the master branch and report back shortly, thanks!

@blommegard
Copy link
Member

@edwardmp How did this go? :)

@skparticles
Copy link

Yes. This issue still there. @objc is missing the respective function.
@objc public init?(countryCode: String) {

@blommegard
Copy link
Member

The generated FlagKit-Swift.h looks like:

enum FKFlagStyle : NSInteger;

SWIFT_CLASS_NAMED("Flag")
@interface FKFlag : NSObject
/// Country code of the flag
@property (nonatomic, readonly, copy) NSString * _Nonnull countryCode;
/// Original unstyled flag image
@property (nonatomic, readonly, strong) UIImage * _Nonnull originalImage;
/// Returns a flag if the country code is supported, otherwise it returns nil
- (nullable instancetype)initWithCountryCode:(NSString * _Nonnull)countryCode OBJC_DESIGNATED_INITIALIZER;
/// Returns a styled flag according to the provided style
/// \param style Desired flag style
///
- (UIImage * _Nonnull)imageWithStyle:(enum FKFlagStyle)style SWIFT_WARN_UNUSED_RESULT;
- (nonnull instancetype)init SWIFT_UNAVAILABLE;
+ (nonnull instancetype)new SWIFT_UNAVAILABLE_MSG("-init is unavailable");
@end

typedef SWIFT_ENUM_NAMED(NSInteger, FKFlagStyle, "FlagStyle", closed) {
/// Rectangle of 21 x 15 points with no styling.
  FKFlagStyleNone = 0,
/// Rectangle of 21 x 15 points with rounded corners.
  FKFlagStyleRoundedRect = 1,
/// Square of 15 x 15 points with rounded corners.
  FKFlagStyleSquare = 2,
/// Circular flag of 15 x 15 points.
  FKFlagStyleCircle = 3,
};

@edwardmp edwardmp closed this as completed Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants