Skip to content
This repository has been archived by the owner on Mar 25, 2019. It is now read-only.

Transcoder accepts new jobs when it can't spawn ffmpeg. #19

Closed
tieleman opened this issue May 9, 2013 · 1 comment
Closed

Transcoder accepts new jobs when it can't spawn ffmpeg. #19

tieleman opened this issue May 9, 2013 · 1 comment
Labels

Comments

@tieleman
Copy link
Contributor

tieleman commented May 9, 2013

When ffmpeg can't be spawned by the transcoder (due to permissions or in some other way the binary can't be found) it still accepts jobs, but these will never finish or complete.

Don't accept jobs if ffmpeg can't be spawned.

@tieleman
Copy link
Contributor Author

Awesome! Thanks for taking the time. What would make it perfect is if there was any error checking on child_process.spawn as well. There are multiple ways spawning can fail (a missing binary is of course the first one), but also for example if the process doesn't have permission to execute the binary.

See: http://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options
(failed exec example)

I think that might be a fail-safe way to check for other spawning errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant