Improve magisk compatibility on AOSP Userdebug build #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a userdebug build device with magisk installed, two
sufiles exist on the same system:/system/xbin/su- added by userdebug config, restricted torootandshellusers/sbin/su- added by magiskDespite the fact that magisk's
suis available, the default logic will attempt to test for/system/xbin/sufirst, resulting in a failed attempt and emptyScriptRunnerresult.Given magisk has gained great popularity over the years, it may worth considering to move
/sbin/suto the first ofDEFAULT_ROOTSso as to improve the overall compatibility.